[Libreoffice-commits] core.git: android/source

Michael Weghorn (via logerrit) logerrit at kemper.freedesktop.org
Thu Mar 18 15:13:49 UTC 2021


 android/source/src/java/org/libreoffice/LOKitThread.java |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 88f4b76270c26ab1d99c14f68cdcbea4b6ee9031
Author:     Michael Weghorn <m.weghorn at posteo.de>
AuthorDate: Thu Mar 18 13:59:14 2021 +0100
Commit:     Michael Weghorn <m.weghorn at posteo.de>
CommitDate: Thu Mar 18 16:13:07 2021 +0100

    tdf#125318 android: Allow copying with editing disabled
    
    Don't make the possibility to select and copy text
    depending on editing being enabled, i.e. experimental
    mode being enabled in Android Viewer.
    
    In a quick test, this worked just fine in read-only mode
    as well, so tapping on text in a document now shows two
    cursors around the tapped word, and allows adapting the
    selection using these and copying to the clipboard
    by using the corresponding toolbar entry.
    
    Change-Id: Icbd9d055a6cc700b78711df178f594c7a9c5cfbf
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112673
    Tested-by: Jenkins
    Reviewed-by: Michael Weghorn <m.weghorn at posteo.de>

diff --git a/android/source/src/java/org/libreoffice/LOKitThread.java b/android/source/src/java/org/libreoffice/LOKitThread.java
index e554f0800cf0..03b7070e783a 100644
--- a/android/source/src/java/org/libreoffice/LOKitThread.java
+++ b/android/source/src/java/org/libreoffice/LOKitThread.java
@@ -448,7 +448,7 @@ class LOKitThread extends Thread {
         boolean editing = LOKitShell.isEditingEnabled();
         float zoomFactor = mViewportMetrics.getZoomFactor();
 
-        if (touchType.equals("LongPress") && editing) {
+        if (touchType.equals("LongPress")) {
             mInvalidationHandler.changeStateTo(InvalidationHandler.OverlayState.TRANSITION);
             mTileProvider.mouseButtonDown(documentCoordinate, 1, zoomFactor);
             mTileProvider.mouseButtonUp(documentCoordinate, 1, zoomFactor);


More information about the Libreoffice-commits mailing list