[Libreoffice-commits] core.git: ucb/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Fri Mar 19 20:58:09 UTC 2021


 ucb/source/ucp/gio/gio_content.cxx |    5 +++++
 1 file changed, 5 insertions(+)

New commits:
commit b4b0fedaee69fd69aaf1e686f22c2ce3606ef52b
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Mar 19 15:39:01 2021 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Mar 19 21:57:26 2021 +0100

    cid#1473830 Resource leak
    
    Change-Id: I221468d7030cf3ebf0425ede29e46febe8ffbe05
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112763
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/ucb/source/ucp/gio/gio_content.cxx b/ucb/source/ucp/gio/gio_content.cxx
index cfce60270c27..ed8eedbadf41 100644
--- a/ucb/source/ucp/gio/gio_content.cxx
+++ b/ucb/source/ucp/gio/gio_content.cxx
@@ -790,6 +790,8 @@ css::uno::Sequence< css::uno::Any > Content::setPropertyValues(
             else
                 mpInfo = pNewInfo;
 
+            pNewInfo = nullptr;
+
             if (mpFile) //Discard and refetch
             {
                 g_object_unref(mpFile);
@@ -801,6 +803,9 @@ css::uno::Sequence< css::uno::Any > Content::setPropertyValues(
         notifyPropertiesChange( aChanges );
     }
 
+    if (pNewInfo)
+        g_object_unref(pNewInfo);
+
     return aRet;
 }
 


More information about the Libreoffice-commits mailing list