[Libreoffice-commits] core.git: sd/qa

Tamás Zolnai (via logerrit) logerrit at kemper.freedesktop.org
Mon Mar 22 18:21:19 UTC 2021


 sd/qa/unit/tiledrendering/tiledrendering.cxx |    3 ---
 1 file changed, 3 deletions(-)

New commits:
commit cb0dfff9a49530f348223e1df54762a3da61aa51
Author:     Tamás Zolnai <tamas.zolnai at collabora.com>
AuthorDate: Mon Mar 22 14:40:48 2021 +0100
Commit:     Tamás Zolnai <tamas.zolnai at collabora.com>
CommitDate: Mon Mar 22 19:20:26 2021 +0100

    Remove this unreliable check.
    
    This check was added to an existing test, instead of adding a new
    test focusing this functionality. In this context, this lock thing is
    not really reliable.
    
    Change-Id: Iad64edba277e714fa7f6b68fdfa8db0bf74851a5
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112892
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Tamás Zolnai <tamas.zolnai at collabora.com>
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112893
    Tested-by: Jenkins

diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index d553dfce610f..107fc9364680 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -1061,9 +1061,6 @@ void SdTiledRenderingTest::testCursorViews()
     // text edit in the first view.
     ViewCallback aView2;
     SfxLokHelper::setView(nView1);
-    // This failed: the second view didn't get a lock notification, even if the
-    // first view already started text edit.
-    CPPUNIT_ASSERT(aView2.m_bViewLock);
     aView2.m_bTilesInvalidated = false;
     pXImpressDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'x', 0);
     pXImpressDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 'x', 0);


More information about the Libreoffice-commits mailing list