[Libreoffice-commits] core.git: android/source

[Michael Weghorn (via logerrit)]

 android/source/AndroidManifest.xml |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 76a30ac646faf1c638736c10e834bb7b0ed243ef
Author:     Michael Weghorn <m.weghorn at posteo.de>
AuthorDate: Mon Mar 22 11:48:47 2021 +0100
Commit:     Michael Weghorn <m.weghorn at posteo.de>
CommitDate: Tue Mar 23 06:55:38 2021 +0100

    Related tdf#129833 android: Drop android.permission.INTERNET
    
    The permission was requested since ownCloud support was added
    in commit 69773f54bbac08953f0fbce16eecea0816e04338
    ("Android: initial implementation of ownCloud provider.",
    2015-01-21).
    
    Since the custom ownCloud support has been dropped in commit
    6012599e17206ee7be9a83477654e7bd194079c3
    ("tdf#129833 android: Drop non-working ownCloud/nextCloud support"),
    there should no longer be any need to require Internet access,
    so drop the permission again.
    
    Access to ownCloud and other Internet services providing file
    access now goes via DocumentProviders, and the corresponding
    apps providing those should take care of
    being allowed to access the internet by themselves.
    
    I tested that opening and editing a file located
    on a NextCloud share still works OK when the NextCloud
    app is installed and set up.
    
    Change-Id: Id8425e7afcd5ecc26d14ba9f42018f536d0a6a6e
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112879
    Tested-by: Jenkins
    Reviewed-by: Michael Weghorn <m.weghorn at posteo.de>

diff --git a/android/source/AndroidManifest.xml b/android/source/AndroidManifest.xml
index 58da19119828..ae37c4fe8054 100644
--- a/android/source/AndroidManifest.xml
+++ b/android/source/AndroidManifest.xml
@@ -9,7 +9,6 @@
     <uses-feature android:name="android.hardware.usb.host" android:required="false"/>
     <uses-feature android:name="android.hardware.camera" android:required="false"/>
     <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
-    <uses-permission android:name="android.permission.INTERNET" />
 
     <!-- extractNativeLibs="true" needed e.g. for NSS to load modules at runtime -->
     <application