[Libreoffice-commits] core.git: sw/qa

[Stephan Bergmann (via logerrit)]

 sw/qa/uitest/writer_tests3/hyperlinkdialog.py |    7 +++++++
 1 file changed, 7 insertions(+)

New commits:
commit 10fbf2b80e11620f3fc1691aa7968e6d3d460db9
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Tue Mar 23 14:24:44 2021 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Wed Mar 24 07:59:40 2021 +0100

    Skip a problematic UITest for --with-help=html/online
    
    Change-Id: I703eba78bb2980ac27dd11f36e03ef86c9662338
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112993
    Reviewed-by: Xisco Fauli <xiscofauli at libreoffice.org>
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>
    Tested-by: Jenkins

diff --git a/sw/qa/uitest/writer_tests3/hyperlinkdialog.py b/sw/qa/uitest/writer_tests3/hyperlinkdialog.py
index c2b9a85b7618..6e28a02b2dfa 100644
--- a/sw/qa/uitest/writer_tests3/hyperlinkdialog.py
+++ b/sw/qa/uitest/writer_tests3/hyperlinkdialog.py
@@ -8,6 +8,7 @@
 #
 
 from uitest.framework import UITestCase
+import os
 import time
 from uitest.uihelper.common import get_state_as_dict, type_text
 from libreoffice.uno.propertyvalue import mkPropertyValues
@@ -81,6 +82,12 @@ class HyperlinkDialog(UITestCase):
         self.ui_test.close_doc()
 
     def test_tdf141166(self):
+        # Skip this test for --with-help=html and --with-help=online, as that would fail with a
+        # DialogNotExecutedException("did not execute a dialog for a blocking action") thrown from
+        # the below execute_blocking_action call (and would leave behind the relevant HTML page
+        # opened in the user's default browser):
+        if os.getenv('ENABLE_HTMLHELP') == 'TRUE':
+            return
 
         self.ui_test.create_doc_in_start_center("writer")
         xWriterDoc = self.xUITest.getTopFocusWindow()