[Libreoffice-commits] core.git: vcl/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Fri Mar 26 17:04:21 UTC 2021


 vcl/source/app/scheduler.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit c700ded8cfc89368141dfbf8baab732f676ad395
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Mar 26 15:10:38 2021 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Mar 26 18:03:30 2021 +0100

    cid#1474074 silence bogus Dereference before null check
    
    Change-Id: I31a64f1f0765659c61fbf5f1a5b32d9705bcc2f8
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113160
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/source/app/scheduler.cxx b/vcl/source/app/scheduler.cxx
index 6ec07d4b020f..ebc08e0f9a84 100644
--- a/vcl/source/app/scheduler.cxx
+++ b/vcl/source/app/scheduler.cxx
@@ -504,6 +504,7 @@ bool Scheduler::ProcessTaskScheduling()
         assert(pSchedulerData == pMostUrgent);
         rSchedCtx.mpSchedulerStack = pSchedulerData->mpNext;
 
+        // coverity[check_after_deref : FALSE] - pMostUrgent->mpTask is initially pMostUrgent->mpTask, but Task::Invoke can clear it
         const bool bTaskAlive = pMostUrgent->mpTask && pMostUrgent->mpTask->IsActive();
         if (!bTaskAlive)
         {


More information about the Libreoffice-commits mailing list