[Libreoffice-commits] core.git: chart2/source chart2/uiconfig

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Wed May 5 14:22:59 UTC 2021


 chart2/source/controller/dialogs/res_BarGeometry.cxx |    3 ++-
 chart2/uiconfig/ui/tp_ChartType.ui                   |    3 +++
 2 files changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 21f53f55f82f12fbee4e0d93ff26d3bb05ec3c55
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed May 5 11:24:48 2021 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Wed May 5 16:22:12 2021 +0200

    Resolves: tdf#142049 expand widget to use unused extra space
    
    Change-Id: I7ff6aa4feeccd790b6176cb60b6adb9b21db0f63
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115135
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/chart2/source/controller/dialogs/res_BarGeometry.cxx b/chart2/source/controller/dialogs/res_BarGeometry.cxx
index da48f4ca608a..182d391aac33 100644
--- a/chart2/source/controller/dialogs/res_BarGeometry.cxx
+++ b/chart2/source/controller/dialogs/res_BarGeometry.cxx
@@ -29,7 +29,8 @@ BarGeometryResources::BarGeometryResources(weld::Builder* pBuilder)
 {
     for (size_t i = 0; i < SAL_N_ELEMENTS(CHART_TYPE); ++i)
         m_xLB_Geometry->append_text(SchResId(CHART_TYPE[i]));
-    m_xLB_Geometry->set_size_request(-1, m_xLB_Geometry->get_height_rows(4));
+    m_xLB_Geometry->set_size_request(-1,
+                                     m_xLB_Geometry->get_height_rows(SAL_N_ELEMENTS(CHART_TYPE)));
 }
 
 void BarGeometryResources::connect_changed(const Link<weld::TreeView&, void>& rLink)
diff --git a/chart2/uiconfig/ui/tp_ChartType.ui b/chart2/uiconfig/ui/tp_ChartType.ui
index e9f8e2ba3ce3..600bf3a4af68 100644
--- a/chart2/uiconfig/ui/tp_ChartType.ui
+++ b/chart2/uiconfig/ui/tp_ChartType.ui
@@ -111,6 +111,8 @@
                   <object class="GtkGrid" id="3dblock">
                     <property name="visible">True</property>
                     <property name="can_focus">False</property>
+                    <property name="hexpand">True</property>
+                    <property name="vexpand">True</property>
                     <property name="row_spacing">3</property>
                     <child>
                       <!-- n-columns=1 n-rows=1 -->
@@ -192,6 +194,7 @@
                           <object class="GtkTreeView" id="shape">
                             <property name="visible">True</property>
                             <property name="can_focus">True</property>
+                            <property name="hexpand">True</property>
                             <property name="vexpand">True</property>
                             <property name="model">liststore1</property>
                             <property name="headers_visible">False</property>


More information about the Libreoffice-commits mailing list