[Libreoffice-commits] core.git: chart2/source

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Sun May 9 09:26:26 UTC 2021


 chart2/source/view/charttypes/VSeriesPlotter.cxx |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 9dcd07b6be5739eecb8d8435e8130b20d4d568f0
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Sun May 9 10:03:45 2021 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Sun May 9 11:25:43 2021 +0200

    clang-tidy error: Returning null reference
    
    [clang-analyzer-core.uninitialized.UndefReturn,-warnings-as-errors]
    
    Change-Id: Idfb848f343d9c71655848a32a19c03c0e6893b7d
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115265
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/chart2/source/view/charttypes/VSeriesPlotter.cxx b/chart2/source/view/charttypes/VSeriesPlotter.cxx
index fda17a91964b..2c62b46cc678 100644
--- a/chart2/source/view/charttypes/VSeriesPlotter.cxx
+++ b/chart2/source/view/charttypes/VSeriesPlotter.cxx
@@ -2285,8 +2285,7 @@ PlottingPositionHelper& VSeriesPlotter::getPlottingPositionHelper( sal_Int32 nAx
     }
     if( !pRet )
         pRet = m_pMainPosHelper;
-    if(pRet)
-        pRet->setTimeResolution( m_nTimeResolution, m_aNullDate );
+    pRet->setTimeResolution( m_nTimeResolution, m_aNullDate );
     return *pRet;
 }
 


More information about the Libreoffice-commits mailing list