[Libreoffice-commits] core.git: xmlsecurity/source

[Noel Grandin (via logerrit)]

 xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 870f8bef3c52cca36afe4fcd48c1beec104082cb
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Mon May 17 12:55:27 2021 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Mon May 17 20:52:11 2021 +0200

    dont leak slot-list in updateSlots
    
    Change-Id: I8882dbd2b5ad7656ec5ff7d47fb2e3dcbcceb5e2
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115700
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
index cf084c7137ad..dd57a28be6da 100644
--- a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
+++ b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
@@ -249,8 +249,6 @@ void SecurityEnvironment_NssImpl::updateSlots()
 //                  continue;
 //              }
             addCryptoSlot(pSlot);
-            PK11_FreeSlot( pSlot ) ;
-            pSlot = nullptr;
 
             if (pSymKey != nullptr)
             {
@@ -261,6 +259,8 @@ void SecurityEnvironment_NssImpl::updateSlots()
 
         }// end of if(pSlot != NULL)
     }// end of for
+
+    PK11_FreeSlotList(soltList);
 }
 
 Sequence< Reference < XCertificate > >