[Libreoffice-commits] core.git: sc/source

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Sat May 22 12:36:41 UTC 2021


 sc/source/ui/attrdlg/scuiexp.cxx |   12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

New commits:
commit 1f85d178f2e9f7a61f35c8ef6feb1592b5002403
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Sat May 22 13:25:02 2021 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Sat May 22 14:35:56 2021 +0200

    fix shutdown leak in ScCreateDialogFactory
    
    Change-Id: I7be0fa457fb11dbc1096042636b641cd09df8b4e
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115987
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sc/source/ui/attrdlg/scuiexp.cxx b/sc/source/ui/attrdlg/scuiexp.cxx
index 44de41d0314f..4351539a9055 100644
--- a/sc/source/ui/attrdlg/scuiexp.cxx
+++ b/sc/source/ui/attrdlg/scuiexp.cxx
@@ -22,19 +22,11 @@
 #include "scdlgfact.hxx"
 #include <sal/types.h>
 
-namespace scui
-{
-static ScAbstractDialogFactory_Impl* GetFactory()
-{
-    static ScAbstractDialogFactory_Impl* pFactory = new ScAbstractDialogFactory_Impl;
-    return pFactory;
-}
-}
-
 extern "C" {
 SAL_DLLPUBLIC_EXPORT ScAbstractDialogFactory* ScCreateDialogFactory()
 {
-    return ::scui::GetFactory();
+    static ScAbstractDialogFactory_Impl aFactory;
+    return &aFactory;
 }
 }
 


More information about the Libreoffice-commits mailing list