[Libreoffice-commits] core.git: sc/source

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Thu May 27 10:33:42 UTC 2021


 sc/source/ui/miscdlgs/acredlin.cxx |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit 0ce42c18e19396e66c70631f8a87072424a5d5c6
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Thu May 27 11:15:37 2021 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Thu May 27 12:33:04 2021 +0200

    fix leaks in ScAcceptChgDlg
    
    Change-Id: Idaa946f06fdfdc1f908cff02cab542b64066763c
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116241
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sc/source/ui/miscdlgs/acredlin.cxx b/sc/source/ui/miscdlgs/acredlin.cxx
index c6137a42d1cd..1f8f06e7a451 100644
--- a/sc/source/ui/miscdlgs/acredlin.cxx
+++ b/sc/source/ui/miscdlgs/acredlin.cxx
@@ -1434,7 +1434,10 @@ void ScAcceptChgDlg::RemoveEntries(sal_uLong nStartAction,sal_uLong nEndAction)
         {
             nAction = pEntryData->nActionNo;
             if (nStartAction <= nAction && nAction <= nEndAction)
+            {
                 aIdsToRemove.push_back(sId);
+                delete pEntryData;
+            }
         }
     }
     while (rTreeView.iter_next(*xEntry));
@@ -1478,6 +1481,7 @@ void ScAcceptChgDlg::UpdateEntries(const ScChangeTrack* pChgTrack, sal_uLong nSt
         if (bRemove)
         {
             rTreeView.remove(*xEntry);
+            delete pEntryData;
 
             if (!bLastEntry)
                 bLastEntry = rTreeView.get_iter_first(*xLastEntry);


More information about the Libreoffice-commits mailing list