[Libreoffice-commits] core.git: svtools/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Fri May 28 07:47:05 UTC 2021


 svtools/source/control/valueset.cxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit e2970060121824650f95421d8d2411840a40311f
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Thu May 27 20:37:50 2021 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri May 28 09:46:22 2021 +0200

    tdf#142150 nothing already selected on MouseUp without previous MouseDown
    
    if mouse down was on tooltip (possible on macOS)
    
    Change-Id: Icb4328fa6977356c3bac5f37d42e99ae8d4e4b98
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116273
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/svtools/source/control/valueset.cxx b/svtools/source/control/valueset.cxx
index c60e557fa140..9e14b49dbe46 100644
--- a/svtools/source/control/valueset.cxx
+++ b/svtools/source/control/valueset.cxx
@@ -504,7 +504,9 @@ bool ValueSet::MouseButtonUp( const MouseEvent& rMouseEvent )
 {
     if (rMouseEvent.IsLeft() && !rMouseEvent.IsMod2())
     {
-        Select();
+        // tdf#142150 MouseUp seen without previous MouseDown
+        if (mnSelItemId)
+            Select();
         return true;
     }
 


More information about the Libreoffice-commits mailing list