[Libreoffice-commits] core.git: Branch 'libreoffice-7-1-4' - svtools/source

[Caolán McNamara (via logerrit)]

 svtools/source/control/valueset.cxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 899634104854ba5fedc616ff0e53b59ad61cc97a
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Thu May 27 20:37:50 2021 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri May 28 11:22:09 2021 +0200

    tdf#142150 nothing already selected on MouseUp without previous MouseDown
    
    if mouse down was on tooltip (possible on macOS)
    
    Change-Id: Icb4328fa6977356c3bac5f37d42e99ae8d4e4b98
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116158
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofauli at libreoffice.org>
    (cherry picked from commit 2a0d5643234cd0989f91589695694c809d82e344)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116159
    Reviewed-by: Adolfo Jayme Barrientos <fitojb at ubuntu.com>
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/svtools/source/control/valueset.cxx b/svtools/source/control/valueset.cxx
index 1d961ad4ad32..5ce7298bf1b8 100644
--- a/svtools/source/control/valueset.cxx
+++ b/svtools/source/control/valueset.cxx
@@ -510,7 +510,9 @@ bool ValueSet::MouseButtonUp( const MouseEvent& rMouseEvent )
 {
     if (rMouseEvent.IsLeft() && !rMouseEvent.IsMod2())
     {
-        Select();
+        // tdf#142150 MouseUp seen without previous MouseDown
+        if (mnSelItemId)
+            Select();
         return true;
     }