[Libreoffice-commits] core.git: filter/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Sat Oct 2 12:13:21 UTC 2021


 filter/source/msfilter/svdfppt.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a6a5927eebd51204f224bac16749ca65b258f772
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Oct 1 17:19:52 2021 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sat Oct 2 14:12:45 2021 +0200

    ofz: MemorySanitizer: use-of-uninitialized-value
    
    Change-Id: I774d7da0304735907da31ca0d7b3bde85718066b
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122954
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx
index e0682f04e453..76b7a8a07701 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -2865,7 +2865,7 @@ void SdrPowerPointImport::ImportPage( SdrPage* pRet, const PptSlidePersistEntry*
                                         {
                                             sal_uInt32 nSpFlags;
                                             rStCtrl.ReadUInt32( nSpFlags ).ReadUInt32( nSpFlags );
-                                            if ( ShapeFlag(nSpFlags) & ShapeFlag::Background )
+                                            if (rStCtrl.good() && ShapeFlag(nSpFlags) & ShapeFlag::Background)
                                             {
                                                 aEscherObjListHd.SeekToBegOfRecord( rStCtrl );
                                                 rSlidePersist.pBObj = ImportObj( rStCtrl, aProcessData, aPageSize, aPageSize, /*nCalledByGroup*/0, /*pShapeId*/nullptr );


More information about the Libreoffice-commits mailing list