[Libreoffice-commits] core.git: basctl/source cui/source desktop/source editeng/source

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Wed Sep 1 06:54:52 UTC 2021


 basctl/source/dlged/dlgedmod.cxx                          |    5 +----
 cui/source/customize/acccfg.cxx                           |    3 ---
 cui/source/dialogs/screenshotannotationdlg.cxx            |    2 --
 cui/source/dialogs/thesdlg.cxx                            |    1 -
 cui/source/options/optaboutconfig.cxx                     |    1 -
 cui/source/options/optgdlg.cxx                            |    1 -
 desktop/source/splash/splash.cxx                          |    3 +--
 editeng/source/accessibility/AccessibleContextBase.cxx    |    2 --
 editeng/source/accessibility/AccessibleStaticTextBase.cxx |    3 +--
 editeng/source/editeng/editdoc.cxx                        |    5 +----
 editeng/source/items/CustomPropertyField.cxx              |    3 +--
 editeng/source/items/paraitem.cxx                         |    6 ++----
 editeng/source/misc/hangulhanja.cxx                       |    3 +--
 editeng/source/uno/unoviwou.cxx                           |    2 +-
 14 files changed, 9 insertions(+), 31 deletions(-)

New commits:
commit eb9d34dadbf78fd09ff39ba46d0e48c6ae9f9940
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Tue Aug 31 14:52:15 2021 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Wed Sep 1 08:54:20 2021 +0200

    clang-tidy:readability-redundant-member-init
    
    Change-Id: I2fc0a1f5a637b3228d8f49ecd0e0769d6872cdc6
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121375
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/basctl/source/dlged/dlgedmod.cxx b/basctl/source/dlged/dlgedmod.cxx
index 3bc5453ad66f..017e4b16c78f 100644
--- a/basctl/source/dlged/dlgedmod.cxx
+++ b/basctl/source/dlged/dlgedmod.cxx
@@ -22,10 +22,7 @@
 
 namespace basctl
 {
-DlgEdModel::DlgEdModel()
-    : SdrModel()
-{
-}
+DlgEdModel::DlgEdModel() {}
 
 DlgEdModel::~DlgEdModel() {}
 
diff --git a/cui/source/customize/acccfg.cxx b/cui/source/customize/acccfg.cxx
index 2701e7204f34..98f965a6ce9e 100644
--- a/cui/source/customize/acccfg.cxx
+++ b/cui/source/customize/acccfg.cxx
@@ -834,9 +834,6 @@ SfxAcceleratorConfigPage::SfxAcceleratorConfigPage(weld::Container* pPage,
     , aFilterAllStr(SfxResId(STR_SFX_FILTERNAME_ALL))
     , aFilterCfgStr(CuiResId(RID_SVXSTR_FILTERNAME_CFG))
     , m_bStylesInfoInitialized(false)
-    , m_xGlobal()
-    , m_xModule()
-    , m_xAct()
     , m_aUpdateDataTimer("UpdateDataTimer")
     , m_xEntriesBox(m_xBuilder->weld_tree_view("shortcuts"))
     , m_xOfficeButton(m_xBuilder->weld_radio_button("office"))
diff --git a/cui/source/dialogs/screenshotannotationdlg.cxx b/cui/source/dialogs/screenshotannotationdlg.cxx
index bdae7f003b8d..802453d2206c 100644
--- a/cui/source/dialogs/screenshotannotationdlg.cxx
+++ b/cui/source/dialogs/screenshotannotationdlg.cxx
@@ -200,9 +200,7 @@ ScreenshotAnnotationDlg_Impl::ScreenshotAnnotationDlg_Impl(
 :   mpParentWindow(pParent),
     mrParentDialog(rParentDialog),
     mxVirtualBufferDevice(nullptr),
-    maAllChildren(),
     mpHilighted(nullptr),
-    maSelected(),
     maPicture(this),
     maSaveAsText(CuiResId(RID_SVXSTR_SAVE_SCREENSHOT_AS))
 {
diff --git a/cui/source/dialogs/thesdlg.cxx b/cui/source/dialogs/thesdlg.cxx
index 19580b007616..a9f4883f4c70 100644
--- a/cui/source/dialogs/thesdlg.cxx
+++ b/cui/source/dialogs/thesdlg.cxx
@@ -240,7 +240,6 @@ SvxThesaurusDialog::SvxThesaurusDialog(
     LanguageType nLanguage)
     : SfxDialogController(pParent, "cui/ui/thesaurus.ui", "ThesaurusDialog")
     , m_aModifyIdle("cui SvxThesaurusDialog LookUp Modify")
-    , aLookUpText()
     , nLookUpLanguage(LANGUAGE_NONE)
     , m_bWordFound(false)
     , m_xLeftBtn(m_xBuilder->weld_button("left"))
diff --git a/cui/source/options/optaboutconfig.cxx b/cui/source/options/optaboutconfig.cxx
index 26e47983f541..39abfbedbadb 100644
--- a/cui/source/options/optaboutconfig.cxx
+++ b/cui/source/options/optaboutconfig.cxx
@@ -137,7 +137,6 @@ CuiAboutConfigTabPage::CuiAboutConfigTabPage(weld::Window* pParent)
     , m_xSearchEdit(m_xBuilder->weld_entry("searchEntry"))
     , m_xPrefBox(m_xBuilder->weld_tree_view("preferences"))
     , m_xScratchIter(m_xPrefBox->make_iterator())
-    , m_vectorOfModified()
     , m_bSorted(false)
 {
     m_xPrefBox->set_size_request(m_xPrefBox->get_approximate_digit_width() * 100,
diff --git a/cui/source/options/optgdlg.cxx b/cui/source/options/optgdlg.cxx
index b353325f1b53..7f5ad32fce0b 100644
--- a/cui/source/options/optgdlg.cxx
+++ b/cui/source/options/optgdlg.cxx
@@ -371,7 +371,6 @@ private:
 };
 
 CanvasSettings::CanvasSettings() :
-    mxForceFlagNameAccess(),
     mbHWAccelAvailable(false),
     mbHWAccelChecked(false)
 {
diff --git a/desktop/source/splash/splash.cxx b/desktop/source/splash/splash.cxx
index e61f87041207..2389e14f4d11 100644
--- a/desktop/source/splash/splash.cxx
+++ b/desktop/source/splash/splash.cxx
@@ -120,8 +120,7 @@ public:
 };
 
 SplashScreenWindow::SplashScreenWindow(SplashScreen *pSplash)
-    : IntroWindow()
-    , pSpl( pSplash )
+    : pSpl( pSplash )
     , _vdev(VclPtr<VirtualDevice>::Create(*GetOutDev()))
 {
     _vdev->EnableRTL(IsRTLEnabled());
diff --git a/editeng/source/accessibility/AccessibleContextBase.cxx b/editeng/source/accessibility/AccessibleContextBase.cxx
index 6683d7eec29d..a4c56bba251d 100644
--- a/editeng/source/accessibility/AccessibleContextBase.cxx
+++ b/editeng/source/accessibility/AccessibleContextBase.cxx
@@ -47,9 +47,7 @@ AccessibleContextBase::AccessibleContextBase (
         const sal_Int16 aRole)
     :   WeakComponentImplHelper(MutexOwner::maMutex),
         mxParent(rxParent),
-        msDescription(),
         meDescriptionOrigin(NotSet),
-        msName(),
         meNameOrigin(NotSet),
         mnClientId(0),
         maRole(aRole)
diff --git a/editeng/source/accessibility/AccessibleStaticTextBase.cxx b/editeng/source/accessibility/AccessibleStaticTextBase.cxx
index e479562935eb..9e73d192b19a 100644
--- a/editeng/source/accessibility/AccessibleStaticTextBase.cxx
+++ b/editeng/source/accessibility/AccessibleStaticTextBase.cxx
@@ -178,8 +178,7 @@ namespace accessibility
 
 
     AccessibleStaticTextBase_Impl::AccessibleStaticTextBase_Impl() :
-        mxTextParagraph( new AccessibleEditableTextPara(nullptr) ),
-        maEditSource()
+        mxTextParagraph( new AccessibleEditableTextPara(nullptr) )
     {
 
         // TODO: this is still somewhat of a hack, all the more since
diff --git a/editeng/source/editeng/editdoc.cxx b/editeng/source/editeng/editdoc.cxx
index 27aa19ed2992..b6269bb7ae06 100644
--- a/editeng/source/editeng/editdoc.cxx
+++ b/editeng/source/editeng/editdoc.cxx
@@ -483,7 +483,6 @@ ExtraPortionInfo::ExtraPortionInfo()
 , nAsianCompressionTypes(AsianCompressionFlags::Normal)
 , bFirstCharIsRightPunktuation(false)
 , bCompressed(false)
-, lineBreaksList()
 {
 }
 
@@ -2717,9 +2716,7 @@ struct LessByStart
 }
 
 CharAttribList::CharAttribList()
-: aAttribs()
-, aDefFont()
-, bHasEmptyAttribs(false)
+: bHasEmptyAttribs(false)
 {
 }
 
diff --git a/editeng/source/items/CustomPropertyField.cxx b/editeng/source/items/CustomPropertyField.cxx
index b90c191a8587..be6b4a626722 100644
--- a/editeng/source/items/CustomPropertyField.cxx
+++ b/editeng/source/items/CustomPropertyField.cxx
@@ -20,8 +20,7 @@ namespace editeng
 {
 
 CustomPropertyField::CustomPropertyField(OUString const & rName, OUString const & rCurrentPresentation)
-    : SvxFieldData()
-    , msName(rName)
+    : msName(rName)
     , msCurrentPresentation(rCurrentPresentation)
 {}
 
diff --git a/editeng/source/items/paraitem.cxx b/editeng/source/items/paraitem.cxx
index 3d097e7f040d..aa15c834846a 100644
--- a/editeng/source/items/paraitem.cxx
+++ b/editeng/source/items/paraitem.cxx
@@ -728,8 +728,7 @@ void SvxTabStop::dumpAsXml(xmlTextWriterPtr pWriter) const
 // class SvxTabStopItem --------------------------------------------------
 
 SvxTabStopItem::SvxTabStopItem( sal_uInt16 _nWhich ) :
-    SfxPoolItem( _nWhich ),
-    maTabStops()
+    SfxPoolItem( _nWhich )
 {
     const sal_uInt16 nTabs = SVX_TAB_DEFCOUNT, nDist = SVX_TAB_DEFDIST;
     const SvxTabAdjust eAdjst= SvxTabAdjust::Default;
@@ -746,8 +745,7 @@ SvxTabStopItem::SvxTabStopItem( const sal_uInt16 nTabs,
                                 const sal_uInt16 nDist,
                                 const SvxTabAdjust eAdjst,
                                 sal_uInt16 _nWhich ) :
-    SfxPoolItem( _nWhich ),
-    maTabStops()
+    SfxPoolItem( _nWhich )
 {
     for ( sal_uInt16 i = 0; i < nTabs; ++i )
     {
diff --git a/editeng/source/misc/hangulhanja.cxx b/editeng/source/misc/hangulhanja.cxx
index 9ea8fba5d8ca..67eb7aae9b3d 100644
--- a/editeng/source/misc/hangulhanja.cxx
+++ b/editeng/source/misc/hangulhanja.cxx
@@ -234,8 +234,7 @@ namespace editeng
                                                             sal_Int32 _nOptions,
                                                             bool _bIsInteractive,
                                                             HangulHanjaConversion* _pAntiImpl )
-        : m_pConversionDialog()
-        , m_pUIParent( pUIParent )
+        : m_pUIParent( pUIParent )
         , m_xContext( rxContext )
         , m_aSourceLocale( _rSourceLocale )
         , m_nSourceLang( LanguageTag::convertToLanguageType( _rSourceLocale ) )
diff --git a/editeng/source/uno/unoviwou.cxx b/editeng/source/uno/unoviwou.cxx
index cbad84836610..19f38794e8c6 100644
--- a/editeng/source/uno/unoviwou.cxx
+++ b/editeng/source/uno/unoviwou.cxx
@@ -24,7 +24,7 @@
 #include <editeng/outliner.hxx>
 
 SvxDrawOutlinerViewForwarder::SvxDrawOutlinerViewForwarder( OutlinerView& rOutl ) :
-    mrOutlinerView ( rOutl ), maTextShapeTopLeft()
+    mrOutlinerView ( rOutl )
 {
 }
 


More information about the Libreoffice-commits mailing list