[Libreoffice-commits] core.git: package/source pyuno/source reportdesign/source salhelper/source sax/source

[Noel Grandin (via logerrit)]

 package/source/xstor/owriteablestream.cxx         |    1 -
 package/source/xstor/xstorage.cxx                 |    2 --
 pyuno/source/module/pyuno_module.cxx              |    1 -
 reportdesign/source/core/sdr/UndoEnv.cxx          |    3 ---
 reportdesign/source/core/sdr/formatnormalizer.cxx |    1 -
 reportdesign/source/ui/dlg/Navigator.cxx          |    3 +--
 salhelper/source/condition.cxx                    |    3 +--
 sax/source/fastparser/fastparser.cxx              |    1 -
 sax/source/tools/fastserializer.cxx               |    4 +---
 9 files changed, 3 insertions(+), 16 deletions(-)

New commits:
commit ad4d09db4a359748f5ecf5e78a3513ef3878e9c1
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Wed Sep 1 08:57:02 2021 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Wed Sep 1 11:20:17 2021 +0200

    clang-tidy:readability-redundant-member-init
    
    Change-Id: Ic5abfe2d047750d8dfd3ae8cc733fa15d34ea505
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121432
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/package/source/xstor/owriteablestream.cxx b/package/source/xstor/owriteablestream.cxx
index 89daf8ccafdb..a049a47a8030 100644
--- a/package/source/xstor/owriteablestream.cxx
+++ b/package/source/xstor/owriteablestream.cxx
@@ -73,7 +73,6 @@ struct WSInternalData_Impl
     // the mutex reference MUST NOT be empty
     WSInternalData_Impl( const rtl::Reference<comphelper::RefCountedMutex>& rMutexRef, sal_Int32 nStorageType )
     : m_xSharedMutex( rMutexRef )
-    , m_pTypeCollection()
     , m_aListenersContainer( rMutexRef->GetMutex() )
     , m_nStorageType( nStorageType )
     {}
diff --git a/package/source/xstor/xstorage.cxx b/package/source/xstor/xstorage.cxx
index 58524e525e85..e8153d4e79aa 100644
--- a/package/source/xstor/xstorage.cxx
+++ b/package/source/xstor/xstorage.cxx
@@ -92,11 +92,9 @@ struct StorInternalData_Impl
     StorInternalData_Impl( const rtl::Reference<comphelper::RefCountedMutex>& rMutexRef, bool bRoot, sal_Int32 nStorageType, bool bReadOnlyWrap )
     : m_xSharedMutex( rMutexRef )
     , m_aListenersContainer( rMutexRef->GetMutex() )
-    , m_pTypeCollection()
     , m_bIsRoot( bRoot )
     , m_nStorageType( nStorageType )
     , m_bReadOnlyWrap( bReadOnlyWrap )
-    , m_pSubElDispListener()
     {}
 };
 
diff --git a/pyuno/source/module/pyuno_module.cxx b/pyuno/source/module/pyuno_module.cxx
index f3c6d92669fb..a5167ef09919 100644
--- a/pyuno/source/module/pyuno_module.cxx
+++ b/pyuno/source/module/pyuno_module.cxx
@@ -94,7 +94,6 @@ class fillStructState
 public:
     fillStructState()
         : used (PyDict_New())
-        , initialised ()
         , nPosConsumed (0)
     {
         if ( ! used )
diff --git a/reportdesign/source/core/sdr/UndoEnv.cxx b/reportdesign/source/core/sdr/UndoEnv.cxx
index 4f7168e4f2e7..45aa4119255d 100644
--- a/reportdesign/source/core/sdr/UndoEnv.cxx
+++ b/reportdesign/source/core/sdr/UndoEnv.cxx
@@ -76,8 +76,6 @@ struct ObjectInfo
     Reference< XPropertySet >   xPropertyIntrospection;
 
     ObjectInfo()
-        :aProperties()
-        ,xPropertyIntrospection()
     {
     }
 };
@@ -108,7 +106,6 @@ public:
 
 OXUndoEnvironmentImpl::OXUndoEnvironmentImpl(OReportModel& _rModel) : m_rModel(_rModel)
         ,m_aFormatNormalizer( _rModel )
-        ,m_aConditionUpdater()
         ,m_nLocks(0)
         ,m_bReadOnly(false)
         ,m_bIsUndo(false)
diff --git a/reportdesign/source/core/sdr/formatnormalizer.cxx b/reportdesign/source/core/sdr/formatnormalizer.cxx
index c4d22941fbf3..ae576bc40747 100644
--- a/reportdesign/source/core/sdr/formatnormalizer.cxx
+++ b/reportdesign/source/core/sdr/formatnormalizer.cxx
@@ -58,7 +58,6 @@ namespace rptui
 
     FormatNormalizer::FormatNormalizer( const OReportModel& _rModel )
         :m_rModel( _rModel )
-        ,m_xReportDefinition( )
         ,m_bFieldListDirty( true )
     {
     }
diff --git a/reportdesign/source/ui/dlg/Navigator.cxx b/reportdesign/source/ui/dlg/Navigator.cxx
index 74b06b080cf3..ed7b2b6f6669 100644
--- a/reportdesign/source/ui/dlg/Navigator.cxx
+++ b/reportdesign/source/ui/dlg/Navigator.cxx
@@ -207,8 +207,7 @@ public:
 }
 
 NavigatorTree::NavigatorTree(std::unique_ptr<weld::TreeView> xTreeView, OReportController& rController)
-    : comphelper::OSelectionChangeListener()
-    , OPropertyChangeListener(m_aMutex)
+    : OPropertyChangeListener(m_aMutex)
     , m_xTreeView(std::move(xTreeView))
     , m_rController(rController)
 {
diff --git a/salhelper/source/condition.cxx b/salhelper/source/condition.cxx
index a83cc753e0a7..9f1408debcdf 100644
--- a/salhelper/source/condition.cxx
+++ b/salhelper/source/condition.cxx
@@ -32,8 +32,7 @@ using namespace salhelper;
  ******************************************************************/
 
 Condition::Condition(osl::Mutex& aMutex)
-    : m_aMutex(aMutex),
-      m_aCondition()
+    : m_aMutex(aMutex)
 {
 }
 
diff --git a/sax/source/fastparser/fastparser.cxx b/sax/source/fastparser/fastparser.cxx
index ce8d8cc16054..86bd8a734b63 100644
--- a/sax/source/fastparser/fastparser.cxx
+++ b/sax/source/fastparser/fastparser.cxx
@@ -407,7 +407,6 @@ ParserData::ParserData()
 Entity::Entity(const ParserData& rData)
     : ParserData(rData)
     , mnProducedEventsSize(0)
-    , mxProducedEvents()
     , mbEnableThreads(false)
     , mpParser(nullptr)
 {
diff --git a/sax/source/tools/fastserializer.cxx b/sax/source/tools/fastserializer.cxx
index 7c4b22a2d9a3..de035f4717fd 100644
--- a/sax/source/tools/fastserializer.cxx
+++ b/sax/source/tools/fastserializer.cxx
@@ -55,9 +55,7 @@ const char sXmlHeader[] = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\
 
 namespace sax_fastparser {
     FastSaxSerializer::FastSaxSerializer( const css::uno::Reference< css::io::XOutputStream >& xOutputStream )
-        : maCachedOutputStream()
-        , maMarkStack()
-        , mbMarkStackEmpty(true)
+        : mbMarkStackEmpty(true)
         , mpDoubleStr(nullptr)
         , mnDoubleStrCapacity(RTL_STR_MAX_VALUEOFDOUBLE)
         , mbXescape(true)