[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - vcl/source

Tor Lillqvist (via logerrit) logerrit at kemper.freedesktop.org
Wed Sep 1 13:05:53 UTC 2021


 vcl/source/outdev/textline.cxx |    5 +++++
 1 file changed, 5 insertions(+)

New commits:
commit 236bbbf7be3144ed469a36ba0690acee2f6fc2f3
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Tue Aug 31 15:02:48 2021 +0300
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Wed Sep 1 15:05:26 2021 +0200

    Stopgap workaround for misspelling wavy underline drawing bug on iOS
    
    Explicity make the rectangle white before drawing the red wavy line.
    Sure, this means that it looks bad if the document background colour
    is not white. Better than how it looks currently, though, with the
    rectangle containing the wavy underline ending up (for unknown
    reasons) black. And most documents have a white background.
    
    Change-Id: I92b2246bbdbd1404e4c48292c3610d1582a56163
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121370
    Tested-by: Tor Lillqvist <tml at collabora.com>
    Reviewed-by: Tor Lillqvist <tml at collabora.com>

diff --git a/vcl/source/outdev/textline.cxx b/vcl/source/outdev/textline.cxx
index 452a9dbfdfe9..4ec59e10c6a8 100644
--- a/vcl/source/outdev/textline.cxx
+++ b/vcl/source/outdev/textline.cxx
@@ -1079,6 +1079,11 @@ void OutputDevice::DrawWaveLine(const Point& rStartPos, const Point& rEndPos, lo
             pVirtDev->SetOutputSizePixel( Size( nWordLength, nWaveHeight * 2 ), false );
             pVirtDev->SetLineColor( GetLineColor() );
             pVirtDev->SetBackground( Wallpaper( COL_TRANSPARENT ) );
+#ifdef IOS
+            // Stopgap workaround for some bug in the iOS-specific vcl code.
+            pVirtDev->SetFillColor( COL_WHITE );
+            pVirtDev->DrawRect( tools::Rectangle( 0, 0, pVirtDev->GetOutputSize().Width(), pVirtDev->GetOutputSize().Height() ) );
+#endif
             pVirtDev->ImplDrawWaveLineBezier( 0, 0, nWordLength, 0, nWaveHeight, fOrientation, nLineWidth );
             rLineCache.insert( pVirtDev->GetBitmapEx( Point( 0, 0 ), pVirtDev->GetOutputSize() ), GetLineColor(), nLineWidth, nWaveHeight, nWordLength, aWavylinebmp );
         }


More information about the Libreoffice-commits mailing list