[Libreoffice-commits] core.git: sd/source

[Caolán McNamara (via logerrit)]

 sd/source/filter/ppt/pptinanimations.cxx |    7 +++++++
 1 file changed, 7 insertions(+)

New commits:
commit 925d26257f0dac02ba5f2c684394d21e60c76fff
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Thu Sep 2 10:01:55 2021 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Sep 3 10:04:17 2021 +0200

    ofz: MemorySanitizer: use-of-uninitialized-value
    
    Change-Id: Ifbbfc5ea8d53fc81b22e9104cd6aea10aad12583
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121504
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sd/source/filter/ppt/pptinanimations.cxx b/sd/source/filter/ppt/pptinanimations.cxx
index 48f354a67a1d..313a724ec639 100644
--- a/sd/source/filter/ppt/pptinanimations.cxx
+++ b/sd/source/filter/ppt/pptinanimations.cxx
@@ -56,6 +56,7 @@
 #include <oox/ppt/pptfilterhelpers.hxx>
 #include <rtl/ustrbuf.hxx>
 #include <rtl/math.hxx>
+#include <sal/log.hxx>
 #include <tools/debug.hxx>
 #include <osl/diagnose.h>
 
@@ -1377,6 +1378,12 @@ void AnimationImporter::importAnimateColorContainer( const Atom* pAtom, const Re
             mrStCtrl.ReadInt32( nFromMode ).ReadInt32( nFromA ).ReadInt32( nFromB ).ReadInt32( nFromC );
             mrStCtrl.ReadInt32( nToMode ).ReadInt32( nToA ).ReadInt32( nToB ).ReadInt32( nToC );
 
+            if (!mrStCtrl.good())
+            {
+                SAL_WARN("filter.ms", "DFF_msofbtAnimateColorData: short read");
+                break;
+            }
+
             if( nBits & 1 )
             {
                 dump( " by=\"" );