[Libreoffice-commits] core.git: vcl/inc vcl/qt5
Michael Weghorn (via logerrit)
logerrit at kemper.freedesktop.org
Tue Sep 21 19:37:49 UTC 2021
vcl/inc/qt5/Qt5AccessibleWidget.hxx | 3 ---
vcl/qt5/Qt5AccessibleWidget.cxx | 4 ----
2 files changed, 7 deletions(-)
New commits:
commit 0ae1c36f319b0c84d5e592f44738e67945eab3a1
Author: Michael Weghorn <m.weghorn at posteo.de>
AuthorDate: Tue Sep 21 14:35:04 2021 +0200
Commit: Michael Weghorn <m.weghorn at posteo.de>
CommitDate: Tue Sep 21 21:37:06 2021 +0200
qt5 a11y: Drop Qt5AccessibleWidget::{text,value}Interface
They're unused and at first glance look like they might
be overriding the non-virtual methods
from 'QAccessibleInterface' with the same name that
do something more useful (calling 'interface_cast'
with the corresponding 'QAccessible::InterfaceType'
param).
Change-Id: I9258a5f9386f9a7d23bb35cfa33e55a169eb753e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122394
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn at posteo.de>
diff --git a/vcl/inc/qt5/Qt5AccessibleWidget.hxx b/vcl/inc/qt5/Qt5AccessibleWidget.hxx
index aacaba9a80c8..54c967bf0ab1 100644
--- a/vcl/inc/qt5/Qt5AccessibleWidget.hxx
+++ b/vcl/inc/qt5/Qt5AccessibleWidget.hxx
@@ -74,9 +74,6 @@ public:
void doAction(const QString& actionName) override;
QStringList keyBindingsForAction(const QString& actionName) const override;
- static QAccessibleValueInterface* valueInterface();
- static QAccessibleTextInterface* textInterface();
-
// QAccessibleTextInterface
void addSelection(int startOffset, int endOffset) override;
QString attributes(int offset, int* startOffset, int* endOffset) const override;
diff --git a/vcl/qt5/Qt5AccessibleWidget.cxx b/vcl/qt5/Qt5AccessibleWidget.cxx
index 65d5faafb918..f49bb59ce0b4 100644
--- a/vcl/qt5/Qt5AccessibleWidget.cxx
+++ b/vcl/qt5/Qt5AccessibleWidget.cxx
@@ -826,10 +826,6 @@ QStringList Qt5AccessibleWidget::keyBindingsForAction(const QString& actionName)
return keyBindings;
}
-QAccessibleValueInterface* Qt5AccessibleWidget::valueInterface() { return nullptr; }
-
-QAccessibleTextInterface* Qt5AccessibleWidget::textInterface() { return nullptr; }
-
// QAccessibleTextInterface
void Qt5AccessibleWidget::addSelection(int /* startOffset */, int /* endOffset */)
{
More information about the Libreoffice-commits
mailing list