[Libreoffice-commits] core.git: embedserv/source

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Thu Sep 30 13:28:29 UTC 2021


 embedserv/source/embed/ed_idataobj.cxx |    2 +-
 embedserv/source/embed/servprov.cxx    |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 4e60d1a4c94332745662cc9154e6711c0d0453dc
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Thu Sep 30 12:44:59 2021 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Thu Sep 30 15:27:52 2021 +0200

    Extended loplugin:referencecasting/redundantcast (clang-cl): embedserv
    
    Change-Id: I342859fbeaffee5d396cbb6ae3e5db41f5cdbb79
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122886
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/embedserv/source/embed/ed_idataobj.cxx b/embedserv/source/embed/ed_idataobj.cxx
index 2f0b4d960b16..ca482a421939 100644
--- a/embedserv/source/embed/ed_idataobj.cxx
+++ b/embedserv/source/embed/ed_idataobj.cxx
@@ -132,7 +132,7 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP EmbedDocument_Impl::GetData( FORMATETC * pForm
             pMedium->tymed = TYMED_ISTORAGE;
             pMedium->pstg = pNewStg;
             pMedium->pstg->AddRef();
-            pMedium->pUnkForRelease = static_cast<IUnknown*>(pNewStg);
+            pMedium->pUnkForRelease = pNewStg;
 
             return S_OK;
         }
diff --git a/embedserv/source/embed/servprov.cxx b/embedserv/source/embed/servprov.cxx
index ebf6c1eb2c28..44eab63dd8b7 100644
--- a/embedserv/source/embed/servprov.cxx
+++ b/embedserv/source/embed/servprov.cxx
@@ -171,7 +171,7 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP_(ULONG) EmbedProviderFactory_Impl::Release()
 COM_DECLSPEC_NOTHROW STDMETHODIMP EmbedProviderFactory_Impl::CreateInstance(IUnknown*,
                                                                             REFIID riid, void** ppv)
 {
-    IUnknown* pEmbedDocument = static_cast<IUnknown*>(static_cast<IPersistStorage*>( new EmbedDocument_Impl( m_xFactory, &m_guid ) ));
+    IUnknown* pEmbedDocument = static_cast<IPersistStorage*>( new EmbedDocument_Impl( m_xFactory, &m_guid ) );
 
     return pEmbedDocument->QueryInterface( riid, ppv );
 }


More information about the Libreoffice-commits mailing list