[Libreoffice-ux-advise] toolbox control / selection semantics ...

[Michael Meeks]

Hi Billy,

On Fri, 2011-09-30 at 08:39 -0700, Billy Charlton wrote:
> So, my pet peeve issue is a Calc bug/feature request first filed in
> *2003* -- and is in the OOo bugzilla at
> https://issues.apache.org/ooo/show_bug.cgi?id=10864 .  I actually
> filed one of the 12 dupes around 2006.

	Heh filing bugs is great, but showing up to help fix them is even more
impressive :-) the bug sounds annoying as you say.

> I always wondered if there was some dark reason this issue kept
> getting backburned when the project was still in OOo.

	Lack of resources.

> Anyway, I've done plenty of C++ and UI development projects so I'm not
> afraid of tackling it, but the codebase is pretty impenetrable for
> someone just starting out on this project.  Pointers welcome! 

	Cool. So the first trick is to get a build, Linux is strongly
recommended for that. When you've done that, poking at things like:

svx/inc/svx/tbcontrl.hxx
	+ SvxFontColorToolBoxControl
and	+ SvxFontColorExtToolBoxControl

	the difference between which -may- be the cause of your issue, if you
poke into:

sw/source/ui/app/swmodule.cxx:   

	You can see that some are 'Ext' control variants and others are not:
    SvxFontColorExtToolBoxControl::RegisterControl(SID_ATTR_CHAR_COLOR2, pMod );
    SvxFontColorExtToolBoxControl::RegisterControl(SID_ATTR_CHAR_COLOR_BACKGROUND, pMod );

	these guys have the separate drop-down vs. select it seems

    SvxColorToolBoxControl::RegisterControl(SID_BACKGROUND_COLOR, pMod );

	and this guy does not. I imagine calc is using the non-Ext controls,
and needs updating.

	As for saving the previous state in the ODF file, perhaps the best
place to shove that is the settings.xml file; poke at
sc/source/filter/xml - near the $ git grep VisibleAreaTop hits :-)

	HTH,

		Michael.

-- 
michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot