[Libreoffice-ux-advise] [REVIEW] LATE FEATURE: Personas in LibreOffice

[Michael Meeks]

Hi there,

	I had a quick read; it -looks- rather low-touch - and the graphic
effect is really pleasant; so I'd be well up for merging this.

( git --no-pager log --numstat -u 255c03d6ad4ed13c456ee621e0af765684a475d2~..4a4627eba410df933d004170d9f5638526acaed2 ;
git --no-pager log --numstat -u 540f090a68ae4375a36d0ee6dfbb4a82f28ac704~..540f090a68ae4375a36d0ee6dfbb4a82f28ac704 ;
git --no-pager log --numstat -u c223e5ff859171adab1597025b30ec2501fc5771~..3f3d0c52ae29b6ab6b2c10a5557714361aa76a26 ) | less

	IIRC we had this feature already for 4.0 for Windows, and this extends
it to Linux+Mac. Having seen some oddness around transparency for Mac in
the past, it would be worth testing there.

	But +1 from me for the -4-0 branch - assuming we can get another couple
of reviews. As a quibble, I'd prefer to see BitmapEx's instead of
BitmapEx*'s being used in the settings - which would simplify the code
and make it less error prone I suspect; BitmapEx::IsEmpty is your
friend :-)

	Otherwise, really nice work !

		Michael.

-- 
michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot