[Libreoffice-ux-advise] [Bug 69358] [Mac] Use OS native toolbar backgrounds / Review toolbar structure

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69358

--- Comment #18 from Jan Holesovsky <kendy at collabora.com> ---
According to the comments,
https://bugzilla.mozilla.org/show_bug.cgi?id=668195#c10 achieves that without
using CoreUI; so I guess we'll want to change it at some stage to use this 2nd
approach.

At the moment, there are 2 remaining pieces

* the header has its own gradient
* there are white frames drawn around the toolbars.

The 2nd problem could be solved by something like:

diff --git a/vcl/osx/salframe.cxx b/vcl/osx/salframe.cxx
index 6b236d6..e592649 100644
--- a/vcl/osx/salframe.cxx
+++ b/vcl/osx/salframe.cxx
@@ -1301,6 +1301,9 @@ void AquaSalFrame::UpdateSettings( AllSettings& rSettings
)

     rSettings.SetStyleSettings( aStyleSettings );

+    // don't draw frame around each and every toolbar
+    ImplGetSVData()->maNWFData.mbDockingAreaAvoidTBFrames = true;
+
     [mpNSView unlockFocus];
 }


Joren - can you please try it?  If it looks good enough, I'll push it, and
build on top of that, so that we don't lose the work done so far :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.