[Libreoffice-ux-advise] [Bug 105566] Show InfoBar when document has invalid signature

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=105566

--- Comment #10 from Samuel Mehrbrodt (CIB) <s.mehrbrodt at gmail.com> ---
(In reply to Heiko Tietze from comment #9)
> Two design issues that might be not your fault: the red is unexpected dark;
> hope you make use of constants (haven't checked this red infobar against
> other errors). The black font on this dark red has not enough contrast,
> either it needs to be light grey or the red becomes brighter. 
> After checking the other document I'm not so sure about whom to blame as
> orange is likely not a default. We must not make the infobar a rainbow :-).
> Please use THE default red and beige.

The foreground color for red and orange is now white.
I don't know what you mean with default red and beige.
There are different levels with different colors. Error is red, warning is
orange, info is yellow.

I took the colors from the classification infobars.

> Workflow: Red infobars are about serious problems and I would not expect to
> be able to "acknowledge" them. So as long the user don't dismiss explicitly
> it should be on top.

I don't understand exactly what you mean here.
Btw I changed the behavior so that the infobar hides when you click the "Show
signatures" button.

> The "Show signatures" function is rather a convenience
> function than a confirmation. (When I changes something and do not save when
> asked for the red infobar has disappeared but the signatures dialog won't be
> shown.)

I don't understand this either.

> My suggestion is to close only with the x (an additional button is too much
> noise).

The button shows the Signatures dialog where you can "fix" the problem. I don't
think that is noise, it helps the user doing the action he is expected to do.

> Nitpick: Buttons are labeled with title style capitalization, and like "Edit
> Document" it has to be "Show Signatures".

Fixed.

> Would be nice to have the same width for buttons (Show Signature is slightly
> longer than Edit Document). But I wouldn't put too much effort in it.

The button width is calculated on demand as different translations need
different widths. So this is wontfix.

Thanks for the comments!

-- 
You are receiving this mail because:
You are on the CC list for the bug.