[Libreoffice-ux-advise] [Bug 118295] Gridlines "Show on colored cells" not working

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=118295

Julien Nabet <serval2412 at yahoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |serval2412 at yahoo.fr
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Julien Nabet <serval2412 at yahoo.fr> ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

I noticed that this option was used with vars or const like:
- bGridOnTop
- VOPT_GRID_ONTOP

    318 IMPL_LINK( ScTpContentOptions, GridHdl, ListBox&, rLb, void )
    319 {
    320     sal_Int32   nSelPos = rLb.GetSelectedEntryPos();
    321     bool    bGrid = ( nSelPos <= 1 );
    322     bool    bGridOnTop = ( nSelPos == 1 );
    323 
    324     pColorFT->Enable(bGrid);
    325     pColorLB->Enable(bGrid);
    326     pLocalOptions->SetOption( VOPT_GRID, bGrid );
    327     pLocalOptions->SetOption( VOPT_GRID_ONTOP, bGridOnTop );
    328 }
=> 
Show : value 0, bGrid = true, bGridOnTop = false
Show on colored cells : value 1, bGrid = true, bGridOnTop = true
Hide : value 2, bGrid = false, bGridOnTop = false
See
https://opengrok.libreoffice.org/xref/core/sc/source/ui/optdlg/tpview.cxx#318


Again the same mix (grid on color/grid on top):
    498             case SCLAYOUTOPT_GRID_ONCOLOR:
    499                 pValues[nProp] <<= GetOption( VOPT_GRID_ONTOP );
    500                 break;
https://opengrok.libreoffice.org/xref/core/sc/source/core/tool/viewopti.cxx#498

Finally the value is used in sc/source/ui/view/gridwin4.cxx: 
    557     bool bGridFirst = !rOpts.GetOption( VOPT_GRID_ONTOP );
...
    715     if ( bGridFirst && ( bGrid || bPage ) )
    716         aOutputData.DrawGrid(*pContentDev, bGrid, bPage);
    717 
    718     aOutputData.DrawBackground(*pContentDev);
    719 
    720     if ( !bGridFirst && ( bGrid || bPage ) )
    721         aOutputData.DrawGrid(*pContentDev, bGrid, bPage);
See
https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/gridwin4.cxx#715

-- 
You are receiving this mail because:
You are on the CC list for the bug.