[Libreoffice-ux-advise] [Bug 95854] Insert comment shortcut doesn't let me edit existing comment

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=95854

--- Comment #16 from Maxim Monastirsky <momonasmon at gmail.com> ---
(In reply to Yousuf Philips (jay) (retired) from comment #9)
> The same shortcut should work for both inserting and editing comments, as it
> used to in 4.4 and below, and as it does in writer, so users dont have to
> learn a new shortcut.
> 
> https://gerrit.libreoffice.org/#/c/31449/
^^^ Actually this was a brilliant idea: We can show the same shortcut for two
different commands, if only we define the first one in a global scope, and the
second one in a module-specific scope (Calc in our case). It is true that the
module-specific command is the one that will be always executed by pressing the
shortcut, but this isn't a problem here, as both commands share the same
execution code. The only remaining problem is that the edit command is disabled
when a cell doesn't have a comment, and so can't be executed. But fortunately
this can be solved by some sdi magic, so the edit command remains visually
disabled, but still can be executed via the api (and thus by a keyboard
shortcut).

An updated attempt is in gerrit:

https://gerrit.libreoffice.org/c/core/+/90354

-- 
You are receiving this mail because:
You are on the CC list for the bug.