[Libreoffice-ux-advise] [Bug 149141] Draw UI/Editing. Allow object creation by clicking if drag size is below threshold

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Wed May 18 14:00:55 UTC 2022


https://bugs.documentfoundation.org/show_bug.cgi?id=149141

--- Comment #5 from ashleighsinclair86 at gmail.com ---
Thanks Buovjaga I'll be sure to add tdf# to the commit message in the next
amendment. 

I should point out a couple of things I'm aware of. Grid snapping rules should
be followed. So if the user has grid snapping enabled the object should be
created centered to the nearest grid rather than the exact click position.

Secondly, in the patch bReturn value will always be true. There is no path
where it can be false. I think bReturn represents wether or not the mouse up
event has been handled successfully, but also seems to be tied to object
creation success. Either way I should check if the default object was created
before assigning bReturn to true. This would maintain the same behaviour as
before.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Libreoffice-ux-advise mailing list