[Libreoffice-ux-advise] [Bug 139963] "Delete spaces and tabs at end and start of line" option in AutoCorrect needs critical evaluation

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=139963

Heiko Tietze <heiko.tietze at documentfoundation.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|needsUXEval                 |
                 CC|libreoffice-ux-advise at lists |heiko.tietze at documentfounda
                   |.freedesktop.org            |tion.org,
                   |                            |tabe at fixedpoint.jp

--- Comment #5 from Heiko Tietze <heiko.tietze at documentfoundation.org> ---
sDelSpaceAtSttEnd = RID_CUISTR_DEL_SPACES_AT_STT_END = "Delete...of paragraph"
= bAFormatDelSpacesAtSttEnd

sDelSpaceBetweenLines = RID_CUISTR_DEL_SPACES_BETWEEN_LINES = "Delete...of
line" = bAFormatDelSpacesBetweenLines

/// Delete beginning and/or end in a node
void SwAutoFormat::DeleteLeadingTrailingBlanks(bool bStart, bool bEnd)
{
    if( !(m_aFlags.bAFormatByInput
        ? m_aFlags.bAFormatByInpDelSpacesAtSttEnd
        : m_aFlags.bAFormatDelSpacesAtSttEnd) )
        return;
...
bAFormatByInpDelSpacesAtSttEnd // "Format/ByInput/DelSpacesAtStartEnd"
bAFormatDelSpacesAtSttEnd  // "Format/Option/DelSpacesAtStartEnd"

Last change by Michael Stahl
https://github.com/LibreOffice/core/commit/c1f1cad3e63afcf6b9bbf6e42f28efa74ec49189

void SwAutoFormat::DelMoreLinesBlanks( bool bWithLineBreaks )
{
    if( !(m_aFlags.bAFormatByInput
        ? m_aFlags.bAFormatByInpDelSpacesBetweenLines
        : m_aFlags.bAFormatDelSpacesBetweenLines) )
        return;
...
bAFormatDelSpacesBetweenLines // "Format/Option/DelSpacesBetween",
bAFormatByInpDelSpacesBetweenLines // "Format/ByInput/DelSpacesBetween"

Last change by Takeshi Abe
https://github.com/LibreOffice/core/commit/10ffbbd269ae14677e7fced9da0268146faae919

UX-wise we should of course remove options that are not functional. And
actually I wonder too what makes spaces at line start/end different from
paragraph.

-- 
You are receiving this mail because:
You are on the CC list for the bug.