[Bug 88918] Edit→Hyperlink… is greyed out when an object with a hyperlink is selected in Draw

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=88918

Regina Henschel <rb.henschel at t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needsUXEval
                 CC|                            |libreoffice-ux-advise at lists
                   |                            |.freedesktop.org

--- Comment #19 from Regina Henschel <rb.henschel at t-online.de> ---
I'm not sure about it. The place where ShouldDisableEditHyperlink() is called
has the comment
1487      // Menuoption: Edit->Hyperlink
1488      // Disable, if there is no hyperlink
And the shortcut shown in the menu is not Ctrl+K but Alt+K and latter means
uno:EditHyperlink.
That would fit to option 2. If you go with option 2, then you get the needed
info by the getHyperlink() method from the selected object. That is easy to do.

The option 3 has the problem, that the ODF file format standard allows objects,
for that a hyperlink is not implemented in LibreOffice or implemented so, that
the hyperlink is written to file but does not work in LibreOffice.
In file format it is the <draw:a> element:
https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part3-schema/OpenDocument-v1.3-os-part3-schema.html#__RefHeading__1415880_253892949
You would get the info which kind of object is selected by the
GetObjIdentifier() method of the selected object. That method returns a value
of the enumeration enum class SdrObjKind. You find an idea about its use in
https://opengrok.libreoffice.org/xref/core/sw/source/uibase/shells/drwbassh.cxx

Option 1 would mean to enable it always, at least I have not seen an example,
where the 'Insert Hyperlink' command from the toolbar is not enabled. It is
even enabled for 3D-scene and group, and for them a hyperlink does not work in
LibreOffice.

I will add UX. They might decide, whether option 2 would be fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.