[Bug 167476] The button selection for the border presets are 'invisible' in Dark-Mode

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=167476

Michael Weghorn <m.weghorn at posteo.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
     Ever confirmed|0                           |1

--- Comment #9 from Michael Weghorn <m.weghorn at posteo.de> ---
(In reply to V Stuart Foote from comment #6)
> Not sure it can be done, but on the same Page Style panel the 'Shadow Style'
> gets a button outline. And when Tools -> Options -> Appearance 'Enable
> application theming' is checked enabled the button outline will respond to
> the application theme's Accent Color as set (rather than os/DE provided
> color).
> 
> So an enhancement might be to use the same button outline for the preset
> button with active selection. It might be a problem as the presets now
> trigger change in the border preview widget, don't think that feature should
> be dropped.

As far as I understand it from looking into the code a bit, the current logic
for the "Presets" control (a ValueSet, like the "Position" one in the "Shadow
Style" section) is that it doesn't have a real permanent selection state beyond
the point in time when it has focus. I.e. it is (currently) primarily meant to
be used to allow a one-time selection of borders that can then be tweaked later
on, by clicking in the "User-defined" control below. But the preset used to
initialize those borders is then (more or less) discarded and the borders shown
in the "User-defined" control are used from that point on to manage state.
(Adding or removing a border in that "User-defined" control would invalidate
any preset previously selected.)

There is an explicit call to `m_xWndPresets->SetNoSelection();` in order to
*not* show a blue (in my case, gtk3 VCL plugin on Linux) selection border for
the currently selected preset, as opposed to what that the "Position" control
in the "Shadow style" section has.

Is the problem discussed here that the currently selected preset isn't clearly
visible while the control has focus (in which case showing the selection border
during that stage might be a solution) or when it doesn't have focus?
(The latter seems to be intentional, at least unless the plan is to change the
general logic.)

Version: 26.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0cada4591d1f7dedbc158ad514adfa2ebaf9ec02
CPU threads: 32; OS: Linux 6.12; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are on the CC list for the bug.