[Bug 167476] The button selection for the border presets are 'invisible' in Dark-Mode

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=167476

Michael Weghorn <m.weghorn at posteo.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=16
                   |                            |7536
             Status|NEEDINFO                    |ASSIGNED
           Assignee|libreoffice-bugs at lists.free |m.weghorn at posteo.de
                   |desktop.org                 |

--- Comment #11 from Michael Weghorn <m.weghorn at posteo.de> ---
(In reply to V Stuart Foote from comment #10)
> "...the problem discussed here that the currently selected preset isn't
> clearly visible while the control has focus (in which case showing the
> selection border during that stage might be a solution)..."
> 
> That is the gist of it.
> 
> Is it as simple as removing the "m_xWndPresets->SetNoSelection()" to allow
> the border preset buttons to show which is active when the button bar has
> focus?

Probably something along these lines, but might still have to clear the
selection when losing focus.

Note that in the context of tdf#167536, these controls were just switched to
use different widgets (IconView instead of ValueSet) yesterday, which makes
this look a little different, but I'd say the overall situation hasn't changed
significantly.

With gtk3, the selection/focus isn't visible at all any more now even with
light theme, but hopefully an approach similar to the one for ValueSet will
work there, too.

I plan to take a closer look later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.