[Libreoffice] [PUSHED] Re: [PATCH] Accelerate perl installer: optimize installer::scriptitems::optimize_list().

[Jordan Ayers]

On Thu, Dec 2, 2010 at 3:23 AM, Caolán McNamara <caolanm at redhat.com> wrote:
> On Tue, 2010-11-30 at 23:02 -0600, Jordan Ayers wrote:
>> Another performance improvement for the perl installer.  This one
>> brought my ./bin/ooinstall -l <dirname> time down from about 4 1/2
>> minutes to under 4 minutes.
>
> Oky doky, pushed. My perl foo is low, but the installer did seem to work
> as normal for me, so in it goes.
>
> C.
>
>

(I just subscribed as well, so I am replying here instead of to the
new thread by Alex / Michael.)

Alex,
    Thanks for the review and notes.  I see how the split / join
changes are more elegant, though I'll have to read up a bit for the
usage of 'grep' to sink in.
    I'm not a perl expert, just have had to learn it on the job over
the last few years.  Since I'm also not very familiar with all the
details the installer is handling, I've been focusing on incremental
cleanup items.  (Although in this case, I suspect that re-deriving the
program would be faster, if someone had enough familiarity with the
install process to do so.)

Jordan Ayers