[Libreoffice] [PUSHED] Re: [PATCH] minor updates to bootstrap/g

[Jan Holesovsky]

Hi Kevin,

On 2010-12-01 at 19:14 -0500, Kevin Hunter wrote:

> > Updated expressions in bootstrap/g so that it uses Bash internal
> > expressions, rather than farming out to the '[' or 'test' external
> > command.
> >
> > Updated deprecated backtick subshell calls to $(
> 
> I've just learned of/realized the not-Bash-specific intended direction 
> of this script, so (and this is probably obvious to Kendy et. al.) the 
> '[' commit is now a no-go (it's a Bash-ism).  The second patch, however, 
> the '$(' update, is not bash-specific, so I believe still good to commit.

Thank you very much, pushed the 2nd patch.  I am not that much against
using bashism in the 'g' script itself, it has other hard to avoid
basisms too, so if others do not object, and you'd like even your 1st
patch applied, please just give me an updated version, and I'll push
that too :-)

Regards,
Kendy