[Libreoffice] [PUSHED][PATCH] RTL_CONSTASCII_USTRINGPARAM for dbaccess/source/ui/dlg

Noel Power nopower at novell.com
Tue Dec 7 04:53:20 PST 2010


Hi Julien
On 06/12/10 21:40, Julien Nabet wrote:
> Hello,
>
> Here's a small patch for dbaccess/source/ui/dlg
>
This is a strange one, it seems SERVICE_UI_FOLDERPICKER is not a simple 
const char but an instance of ConstAsciiString ( defined in 
dbaccess/source/inc/constasciistring.hxx ) so I changed the patch as follows

-                    ::rtl::OUString sFolderPickerService = 
::rtl::OUString::createFromAscii(SERVICE_UI_FOLDERPICKER);
+                    ::rtl::OUString 
sFolderPickerService(SERVICE_UI_FOLDERPICKER);

it seems that there is already an operator to return an OUString& . 
Caolan, this is a new one on me, you seen it before? Does that look like 
we might have problems if we converted similar definitions as  
presumeably RTL_CONSTASCII_USTRINGPARAM would try to take sizeof( 
ConstAsciiString )  in that case

I committed the variation above


Noel


More information about the LibreOffice mailing list