[Libreoffice] Patch review for Bug 32196 requested

[Norbert Thiebaud]

On Tue, Dec 7, 2010 at 7:12 PM, Kohei Yoshida <kyoshida at novell.com> wrote:
> Hi Norbert,
>
> On Tue, 2010-12-07 at 17:03 -0600, Norbert Thiebaud wrote:
>> On Tue, Dec 7, 2010 at 4:45 PM, Kohei Yoshida <kyoshida at novell.com> wrote:
>> > I've attached a patch awaiting peer-review.
>> >
>> > https://bugs.freedesktop.org/show_bug.cgi?id=32196
>> >
>> > The change is simple and innocuous enough that I would almost commit it
>> > without review, but I'd like someone to take a quick look and give me a
>> > go.
>> >
>>
>> Shouldn't you test if you need it _before_ actually constructing it ?
>
> Good point.  Revised.
>
> Are you willing to sign off of this by any chance?

Looks good to me. much better than using an initialized array of chars
anyway :-)

Norbert

>
> Kohei
>
> --
> Kohei Yoshida, LibreOffice hacker, Calc
> <kyoshida at novell.com>
>
>