[Libreoffice] [PATCH] nuke obsolete use of String

[Takeshi Abe]

Hi Caolán,

On Sun, 12 Dec 2010 21:05:38 +0000, Caolán McNamara <caolanm at redhat.com> wrote:
> This is good stuff, I didn't push this yet though. There's one little
> easily-fixed snag I think, e.g.
> 
> - else if ( aArgStr.CompareToAscii( "-psn", 4 ) == COMPARE_EQUAL )
> + else if
> ( aArg.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM("-psn")))
> 
(snip)
> So, that one should be (I think, I get a little confused when I mix my
> strings, double check me) matchAsciiL to be exactly the same as before.
Yes, you are right. Thanks for pointing it out.
So I amend my patch as attached, which still allows the users to pass
rather cooler option -psn_is_not_PlayStation_Network than just -psn to
soffice, both resulting in the same effect ;)

> 
> C.
> 
> p.s. I think we should have a wiki page to list the old String methods
> and the new OUString equivalents side-by-side with snags listed. (Some
> of the String methods are sort of OUStringBuffer equivalents, and some
> are hard to do with OUStrings, and might have workarounds in
> comphelper). Maybe you, or someone else, could start a page in the wiki
> and just start with the methods used in this example
It sounds great, so I created a table at the end of
http://wiki.documentfoundation.org/Development/String_Classes
which now contains only some functions but will be added more.

Cheers,
-- Takeshi Abe