[Libreoffice] vcl/unx: remove duplicate printer code

Joachim joachim.tremouroux at gmail.com
Wed Dec 15 10:58:45 PST 2010


Hi,

I have found some duplicate classes between vcl/unx and 
vcl/unx/headless; PspSalInfoPrinter and PspSalPrinter.
As suggested by Caolàn, the attached patch removes these two classes 
from vcl/unx/headless

- The following removed methods were not strictly identical to the 
existing:
BOOL PspSalInfoPrinter::Setup( SalFrame* pFrame, ImplJobSetup* pJobSetup )
void vcl_sal::PrinterUpdate::doUpdate()
void vcl_sal::PrinterUpdate::update()

- libvclplug_svpxl.so generated by vcl/unx/headless is now indirectly 
linked with X11, something probably not desired for a headless library.

- There are still lot of common code between SvpSalInstance and 
X11SalInstance.
I will move that common code in a base class. UnxSalInstance seems a 
good name...
That code consists at least of CreateInfoPrinter, CreatePrinter, some 
helper functions, and probably some mutex related code.
Any comment/suggestion on this idea are welcome...


Regards,
Joachim.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: vclunx_remove_duplicate_class.patch
Type: text/x-patch
Size: 32659 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20101215/8b1e3014/attachment-0001.bin>


More information about the LibreOffice mailing list