[Libreoffice] [PUSHED] Re: [PATCH] sw: reset num level on SplitNode if parent is outline.

Caolán McNamara caolanm at redhat.com
Thu Dec 16 01:39:54 PST 2010


On Tue, 2010-12-14 at 23:16 -0800, Octavio Alvarez wrote:
> On Tue, 14 Dec 2010 21:59:37 -0800, Octavio Alvarez  
> <alvarezp at alvarezp.ods.org> wrote:
> 
> > Fixes the following scenario:
> > 1. Create a paragraph style "S" bound to a list style.
> > 2. Set the Heading 2 next style to "S".
> > 3. Pressing ENTER at the end of a Heading 2 will create the new
> >    paragraph, but its numbering level will be set to 2.
> >
> > If this test is repeated for "Heading 3", the resulting paragraph
> > will end up with numbering level == 3.
> > ---
> 
> It turns out it fixes an old bug i#93970, so I'm resending the patch  
> (attached)
> with this notice on the commit message.

This seems reasonable to me and sane, so now pushed to master. Thanks
for this :-)

There might be some side effects I'm unaware of, but the outcome looks
sane and the new behaviour logical so lets go for it, and sort out any
problems if they arise in the future. (With the best route IMO to get
some cppcheck build-time tests into sw like we have for sc and starmath
and accumulate a test-case for this area to lock-down the desired
behaviour for different scenarios and gotchas as they arise)

C.



More information about the LibreOffice mailing list