[Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for framework properties

[Julien Nabet]

Le 18/12/2010 13:47, Caolán McNamara a écrit :
> On Sat, 2010-12-18 at 02:41 +0100, Julien Nabet wrote:
>    
>> Hello,
>>
>> Here is a patch for properties.h of framework
>> framework compiles ok.
>>      
> Looks good, thanks for this. Pushed.
>
> C.
>
>
>    
Hello,

I made a global fgrep for searching the remaining createFromAscii we 
could remove.
I manually removed the cases where I thought createFromAscii must stay.

But I saw 2 cases in this searching where I don't know if we can replace 
createFromAscii :
- e.g. in components/forms/source/misc/services.cxx :    
aServices.getArray()[0] = rtl::OUString::createFromAscii( 
"com.sun.star.xforms." #name );
- e.g. in ure/sal/workben/measure_oustrings.cxx:    std::cout << 
"rtl::OUString::createFromAscii(\"XXXXXXXX\") " << nEndTime - nStartTime 
<< "ms" << std::endl;

And about macros that use createFromAscii, should we remove them ?

Julien.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: test_fgrep.txt
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20101219/5b1e0ea9/attachment.txt>