[Libreoffice] [PATCH] remove dead codes never passed through even in case of MACOSX

Takeshi Abe tabe at fixedpoint.jp
Wed Dec 22 08:12:40 PST 2010


Hi Radek,

On Wed, 22 Dec 2010 12:02:57 +0100, Radek Doulik <rodo at novell.com> wrote:
>> Still loitering on EasyHack 3.7, I encountered dead codes as attached.
>> They seems safely removable because if -psn given, the call of
>> InterpretCommandLineParameter() will catch it and return sal_True, so
>> the lines in question will be never passed through.
>> It looks odd noneththeless. Any thought?
> 
> couldn't be then typo in InterpretCommandLineParameter? maybe it should
> #ifndef it in case of MACOSX, so that the other part makes sense? I
> don't have any OOo CVS tree at hand now, but Thorsten might know.
The lines surrounded by #ifdef/#endif in InterpretCommandLineParameter()
are indeed only for Mac OS X, according to the original issue:
http://qa.openoffice.org/issues/show_bug.cgi?id=84053
You can browse corresponding OOo codes at:
http://svn.services.openoffice.org/opengrok/xref/Current%20(trunk)/desktop/source/app/cmdlineargs.cxx

Cheers,
-- Takeshi Abe


More information about the LibreOffice mailing list