[Libreoffice] Test script patch review request(0)

Yifan Jiang yfjiang at novell.com
Fri Dec 24 01:20:45 PST 2010


Dear people,

I've updated several test scripts and intended to make them more reliable. I
have tested them in SUSE Linux. Could you help review the patches and if
possible help run relevant cases in various platforms. Thank you all for
concerning and help!

The belowing is the outline and details in the patch

* 0001-use-uno-to-invoke-File-Digital-Signature-dialog.patch

    Old method to callout the dialog by count menu item number. This is always
    failed here with Gdoc extension installed, which adds a menu item.
    
* 0003-more-stable-export-graphic-test.patch

    do not verify exported SVG content, instead just verify the exported
    file is existed. Because the difference against OO.o is, SVG will be
    rendered by Libreoffice Draw directly instead of imported as
    ASCII with Writer (which was used by the old script to verify the
    content).

    So at this point we lose some verification points which were used in old
    script, which got the svg content verification involveds. Is it really
    necessary? If necessary, do you have some ideas to verify this without
    using Writer to open the SVG?

    Also the patch replace an inexisted testing picture to an existed one

* 0004-use-uno-slot-to-click-File-Save-as-in-Base.patch

    Reason is the same as 0001.

* 0005-slideshow-test-case-update.patch

  1. give a more safe coordination for drawing rectangle in the slide page

     otherwise the testtool may accidently 'click insert chart
     icon in the slide page' when trying to 'drawing a rectangle'

  2. use uno slot to call Slide Show -> Custom Slide Show. just because I
  think it should be better :)

Best wishes,
Yifan


More information about the LibreOffice mailing list