[Libreoffice] [PUSHED] Re: [PATCH] removed unnecessary comments and whitespaces, dead code, some German translated

Caolán McNamara caolanm at redhat.com
Tue Nov 2 07:54:10 PDT 2010

On Mon, 2010-11-01 at 22:06 +0100, Marcin "eXine" M. wrote:

Looks mostly good, thanks for this. Just three little things

In cui/source/customize/cfgutil.cxx the body of
SfxConfigFunctionListBox_Impl::MouseMove was commented out, so you
removed the full method. That mightn't be the right thing to do as I
see that its a virtual method and so doing nothing is different to
defaulting to use the parent method. So I left the method in, but
removed its all-comments contents to make it empty.

I think you cut a little too deep in cui/source/dialogs/charmap.src.
There was an extra chunk between two comments which got deleted.

In cui/source/dialogs/linkdlg.cxx the comment
"UpdateTimer fuer DDE-/Grf-Links, auf die gewarted wird" was removed, so
I dropped that bit of the patch in the hope that someone can translate
it into english.


More information about the LibreOffice mailing list