[Libreoffice] [PATCH] Renaming extension options

Sebastian Spaeth Sebastian at SSpaeth.de
Fri Nov 5 00:01:58 PDT 2010


On Thu, 04 Nov 2010 21:26:43 +0200, Niko Rönkkö <ronkko at iki.fi> wrote:

> Renamed all extensions to --with-ext-*

Thanks, that makes sense, I just didn't get to it. I'd just still argue
for --enable rather than --with.

> If "we do want to present them together in ./configure --help",
> then they all must be a same type of.
> => Changed all extensions to be AC_ARG_WITH

--enable is being used to choose "optional features" which certainly
  applies here
  (http://www.delorie.com/gnu/docs/autoconf/autoconf_131.html)

--with is used if you require external software and decides which
  external software is being used. (http://www.delorie.com/gnu/docs/autoconf/autoconf_130.html)

So --enable is IMHO what we really want here. What I would prefer even
more is a grouping feature, ie present all extensions in a group,
present all Windows-specific options in a group etc. But I did not find
if that is possible. Does any auto-wizard know?

> Also: We don't want to break builders scripts (as Michael Meeks said) so
> deprecated old options not removed but commented instead.

While I agree for the 3.3 branch. I don't think that doubling the output
of ./configure --help is going to be helpful. It complains when being
invoked with an unknown option anyway. But we can deprecate it for a
while and remove it a bit later. shrug.

Sebastian


More information about the LibreOffice mailing list