On Mon, 2010-11-08 at 00:53 +0200, Ricardo Moreno wrote:
> here is more commented code removal.
Reviewed and applied the part against the 'sc' module. Thanks a lot!
I removed everything except for the one in sc/inc/compiler.hxx (below).
@@ -101,13 +101,6 @@ class ScTokenArray;
// constants and data types internal to compiler
-/*
- OpCode eOp; // OpCode
- formula::StackVar eType; // type of data
- USHORT nRefCnt; // reference count
- BOOL bRaw; // not cloned yet and trimmed to real size
- */
-
#define SC_TOKEN_FIX_MEMBERS \
OpCode eOp; \
formula::StackVar eType; \
That comment there was clearly used to annotate the defined macros
immediately below it, so I considered it'd be better to keep that one.
The other parts of your patch have not been reviewed yet.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida at novell.com>