[Libreoffice] [Patch] + Question about compilation warning on sd/source/ui/view/drviewsj.cxx

[julien]

Hello,

The patch contains only the removing of comments. I haven't removed 1
line of comment because i don't know what "Wieder raus" mean.
I would have like to remove a warning too since during compilation, I
got this :
/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/sd/source/ui/view/drviewsj.cxx:
In member function 'void sd::DrawViewShell::GetMenuStateSel(SfxItemSet&)':
/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/sd/source/ui/view/drviewsj.cxx:301:
warning: declaration of 'rMarkList' shadows a previous local
/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/sd/source/ui/view/drviewsj.cxx:79:
warning: shadowed declaration is here

The lines 79 and 301 contain this :
const SdrMarkList&  rMarkList = mpDrawView->GetMarkedObjectList();

So i tried on line 301 to remove "const SdrMarkList&" to have this :
rMarkList = mpDrawView->GetMarkedObjectList();

I got this :
/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/sd/source/ui/view/drviewsj.cxx:
In member function 'void sd::DrawViewShell::GetMenuStateSel(SfxItemSet&)':
/home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/sd/source/ui/view/drviewsj.cxx:301:
error: passing 'const SdrMarkList' as 'this' argument of 'void
SdrMarkList::operator=(const SdrMarkList&)' discards qualifiers

Perhaps line 301 is just a bad copy-paste but it would be surprising.

What do you think ?

PS : it seems that there are some comments in german in it which could
be useful to translate.

Julien.


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: drviewsj.txt
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20101110/aa42881b/attachment.txt>