[Libreoffice] [PUSHED] + question RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity/source/drivers/adabas/

David Tardon dtardon at redhat.com
Sun Nov 14 22:03:04 PST 2010


On Sun, Nov 14, 2010 at 10:57:57PM +0100, Julien Nabet wrote:
> Hello,
> 
> Here's a patch (LGPLv3+ / MPL) for
> libs-core/connectivity/source/drivers/adabas/

Pushed.

> 
> Concerning the file connectivity/source/drivers/adabas/Buser.cxx, in
> the function :
> ::rtl::OUString OAdabasUser::getPrivilegeString(sal_Int32 nRights) const
> from the file :
> connectivity/source/drivers/adabas/Buser.cxx
> 
> Should'nt there be a block like this for INSERT part (at the
> beginning of the function) :
>         if(sPrivs.getLength())
>             sPrivs += ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(","));
> ?

No, because you do know that the length is 0 .-)

D.


More information about the LibreOffice mailing list