[Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.

Joachim Trémouroux joachim.tremouroux at gmail.com
Mon Nov 22 04:59:29 PST 2010


I have fixed some compilation warnings in binfilter and some unnecessary
comments. Patch is attached for review.

I have two questions:
 - /*N*/ . Should I fix them massively? I have currently left them unchanged
to avoid a big cleanup patch.
 - Unused parameters in some methods are triggering compilation warnings.
Should I fix them by removing the parameter name ?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20101122/75f7cb1a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix_compilation_warning.patch
Type: text/x-patch
Size: 3217 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20101122/75f7cb1a/attachment.bin>

More information about the LibreOffice mailing list