[Libreoffice] [PATCH] i18npool/ : minor memory leak

Caolán McNamara caolanm at redhat.com
Mon Nov 22 08:03:30 PST 2010


On Mon, 2010-11-22 at 10:30 -0500, Kevin Hunter wrote:
> Hullo List,
> 
> Minor memory leak (but a leak nonetheless), found thanks to cppcheck and 
> Jesse's appreciated webpage.

Emm, I'm unconvinced its a memory leak. Its given to maLookupTable and
in lcl_LookupTableHelper::~lcl_LookupTableHelper its always released,
no ?

Specifically I think cppcheck is confused by

maLookupTable.push_back(pNewItem = new
LocaleDataLookupTableItem(aLibTable[i].pLib, module,
aLibTable[i].pLocale ));

and that

LocaleDataLookupTableItem* pNewItem = new
LocaleDataLookupTableItem(aLibTable[i].pLib, module,
aLibTable[i].pLocale );
maLookupTable.push_back( pNewItem );

is sufficient to un-confuse it.

C.



More information about the LibreOffice mailing list