[Libreoffice] [PUSHED] Re: [PATCH] Clean code at writer [source/filter/{ascii, basflt, html}]

Kayo Hamid revol.code at yahoo.com
Mon Nov 22 09:13:32 PST 2010

Thanks for your review, I'll take into account in the next patch.
I kept stuff like
// 0.01mm = 0.57twip 
as that's a useful comment IMO

and I kept stuff like

 void SwHTMLParser::EndNumBulListItem( int nToken, sal_Bool bSetColl, 
-                                      sal_Bool /*bLastPara*/ ) 
+                                      sal_Bool ) 

as that's a common enough pattern which I don't have a problem with
where the argument is commented out to avoid a compiler warning when
someone has to override a method but doesn't need a particular argument
in the overridden method, and it helps comment what that other argument
is for.

Otherwise, happy with the rest of it and pushed it now. Thanks for this.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20101122/ac7b90cc/attachment.html>

More information about the LibreOffice mailing list