[Libreoffice] [PUSHED] Remove dead codes and undesired comments with fixed typo

Michael Meeks michael.meeks at novell.com
Fri Nov 26 02:25:33 PST 2010


Hi Takeshi,

On Fri, 2010-11-26 at 01:48 +0900, Takeshi Abe wrote:
> yet another cleanup on base.

	Great to see you fixing English spellings :-)

>      switch( nColId )
>      {
>          //////////////////////////////////////////////////////////////
> -        // NameCell
> -        case FIELD_NAME:
> -        {
> -            // removed the former duplicate-check. this is done in OTableDocShell::CheckDefConsistency now.
> -            // FS - 07.12.99 - 69575
> -
> -        } break;

	By removing this case statement, we could change the control flow of
course - so FIELD_NAME will go through to a default statement, but in
this case - the is none - so it's fine :-)
	

>          case FIELD_PROPERTY_NUMTYPE:
>              OSL_ENSURE(sal_False, "OTableEditorCtrl::GetCellData: invalid column!");
> -            //	return pFieldDescr->GetNumType();
> +            break;

	This again looks like an inadvertent drop-through; though presumably
~never called.
 
> -    } // if(!_bSet && _pFieldDesc->getTypeInfo()->bNullable)
> +    }

	Odd isn't it :-)

	This is some lovely work - thanks !

	Pushed,

		Michael.

-- 
 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot




More information about the LibreOffice mailing list